From b93cc4ee4a11a5764a2bea53d9763128a1578463 Mon Sep 17 00:00:00 2001 From: JustOff Date: Sat, 19 Jan 2019 14:08:11 +0200 Subject: [PATCH] Don't try to sort add-on versions with the same creation date (March 5, 2007 AMO API bug) --- content/addon.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/addon.js b/content/addon.js index 0efe49c..aa9d977 100644 --- a/content/addon.js +++ b/content/addon.js @@ -36,7 +36,7 @@ let Addon = { data.count = dbQuery.row.count; dbQuery.finalize(); - dbQuery = db.createStatement("SELECT addons.addon_id AS addon_id, addons.name AS name, slug, is_experimental, users, reviews, rating, summary, description, homepage, dev_comments, support_email, support_url, r1, r2, r3, r4, r5, version, release_notes, is_restart_required, versions.url AS url, min, max, size, created, licenses.name AS lic_name, licenses.url AS lic_url, eulas.rowid AS eula, policies.rowid AS policy, icon FROM addons INNER JOIN versions ON addons.addon_id = versions.addon_id LEFT JOIN licenses ON licenses.license_id = versions.license_id LEFT JOIN eulas ON eulas.addon_id = addons.addon_id LEFT JOIN policies ON policies.addon_id = addons.addon_id LEFT JOIN icons ON addons.addon_id = icons.addon_id WHERE addons." + col + " = :query ORDER BY versions.created DESC, versions.version DESC LIMIT 1"); + dbQuery = db.createStatement("SELECT addons.addon_id AS addon_id, addons.name AS name, slug, is_experimental, users, reviews, rating, summary, description, homepage, dev_comments, support_email, support_url, r1, r2, r3, r4, r5, version, release_notes, is_restart_required, versions.url AS url, min, max, size, created, licenses.name AS lic_name, licenses.url AS lic_url, eulas.rowid AS eula, policies.rowid AS policy, icon FROM addons INNER JOIN versions ON addons.addon_id = versions.addon_id LEFT JOIN licenses ON licenses.license_id = versions.license_id LEFT JOIN eulas ON eulas.addon_id = addons.addon_id LEFT JOIN policies ON policies.addon_id = addons.addon_id LEFT JOIN icons ON addons.addon_id = icons.addon_id WHERE addons." + col + " = :query ORDER BY versions.created DESC LIMIT 1"); dbQuery.params.query = query; dbQuery.executeStep(); let id;