From dd1bee2c3ccdaa01274cbf3a57ecaad46e49a40d Mon Sep 17 00:00:00 2001 From: Yotam Mann Date: Tue, 14 Feb 2017 14:45:03 -0500 Subject: [PATCH] try/catch on midi events when a device was plugged in it sometimes emitted a noteoff without a noteon which caused an error --- static/src/keyboard/Midi.js | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/static/src/keyboard/Midi.js b/static/src/keyboard/Midi.js index 3d82d54..a0055c0 100644 --- a/static/src/keyboard/Midi.js +++ b/static/src/keyboard/Midi.js @@ -47,10 +47,18 @@ class Midi extends events.EventEmitter{ } }) inputDevice.addListener('noteon', 'all', (event) => { - this.emit('keyDown', event.note.number) + try { + this.emit('keyDown', event.note.number) + } catch(e){ + console.warn(e) + } }) inputDevice.addListener('noteoff', 'all', (event) => { - this.emit('keyUp', event.note.number) + try { + this.emit('keyUp', event.note.number) + } catch(e){ + console.warn(e) + } }) } }